Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unset values (like null or undefined) when resolving the classList for intellisense #9385

Merged
merged 2 commits into from Sep 21, 2022

Conversation

RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented Sep 21, 2022

This PR fixes an issue that whenever you "unset" a value, that it still provides this information in
the intellisense plugin. This happens because the getClassList was not filtering out those falsey
values.

Note: We are not removing all falsey values (like 0) otherwise p-0 won't be provided anymore.

Fixes: tailwindlabs/tailwindcss-intellisense#609

We are not completely ignoring "all" falsey values, because then we
would get rid of `0` values (e.g.: `p-0`) which is not what we want.
@RobinMalfait RobinMalfait changed the title Ignore unset values for intellisense Ignore unset values (like null or undefined) when resolving the classList for intellisense Sep 21, 2022
@RobinMalfait RobinMalfait merged commit e625252 into master Sep 21, 2022
@RobinMalfait RobinMalfait deleted the fix/undefined-values-for-intellisense branch September 21, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined doesn't remove the class
1 participant