Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose context.sortClassList(classes) #7412

Merged
merged 5 commits into from Feb 10, 2022
Merged

Expose context.sortClassList(classes) #7412

merged 5 commits into from Feb 10, 2022

Conversation

RobinMalfait
Copy link
Contributor

This PR will expose sortClassList on the context

This function will be used by the prettier-plugin-tailwindcss plugin, this way the sorting happens within Tailwind CSS itself adn the prettier-plugin-tailwindcss plugin doesn't have to use internal / private APIs.

The signature looks like this:

function sortClassList(classes: string[]): string[]

E.g.:

let sortedClasses = context.sortClassList(['p-1', 'm-1', 'container'])

@RobinMalfait
add prettier-plugin-tailwindcss
ba80553 
This will use the prettier plugin in our tests as well, yay consistency!
@RobinMalfait
ensure that both group and peer can't be used in @apply
5807529 
This was only configured for `group`
@RobinMalfait RobinMalfait force-pushed the group-and-peer-order branch 2 times, most recently from 05ffe24 to 19a2340 Compare February 10, 2022 16:41
@RobinMalfait
expose sortClassList on the context
a441d91 
This function will be used by the `prettier-plugin-tailwindcss` plugin,
this way the sorting happens within Tailwind CSS itself adn the
`prettier-plugin-tailwindcss` plugin doesn't have to use internal /
private APIs.

The signature looks like this:
```ts
function sortClassList(classes: string[]): string[]
```

E.g.:
```js
let sortedClasses = context.sortClassList(['p-1', 'm-1', 'container'])
```
@RobinMalfait
update changelog
974d543
@RobinMalfait
add sort test for utilities with the important modifier e.g.: !p-4
ba5a562
@RobinMalfait RobinMalfait mentioned this pull request Feb 10, 2022
Merged
@RobinMalfait RobinMalfait merged commit 96d4ce2 into master Feb 10, 2022
@RobinMalfait RobinMalfait deleted the group-and-peer-order branch February 10, 2022 17:06
ruohola added a commit to apilytics/apilytics that referenced this pull request Feb 10, 2022
@ruohola
Update all dependencies to latest
d928e0d 
The Prettier reformatting havoc was caused by:
tailwindlabs/tailwindcss#7412
@ruohola ruohola mentioned this pull request Feb 10, 2022
Merged
@dargmuesli
Copy link

I'm the biggest lover of sorting, but this broke my CI 😄

@thecrypticace
Copy link
Contributor

Can you provide details on how it broke?

@thecrypticace
Copy link
Contributor

nvm I think I can see the problem 🤦‍♂️

@dargmuesli
Copy link

Sure, linting fails https://github.com/maevsi/maevsi/runs/5148080329?check_suite_focus=true#step:5:1288

@thecrypticace
Copy link
Contributor

Fixed! Just published v3.0.21. We added the prettier plugin for internal usage so our tests are consistent and it was mistakenly put in dependencies. Sorry about that and thanks for the report!

dukex added a commit to dukex/tailwindcss-rails that referenced this pull request Feb 15, 2022
@dukex
Update tailwindcss to v3.0.22
5ac6105 
# CHANGELOG

## [3.0.22] - 2022-02-11

### Fixed

- Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424))

## [3.0.21] - 2022-02-10

### Fixed

- Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418))

## [3.0.20] - 2022-02-10

### Added

- Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412))

## [3.0.19] - 2022-02-07

### Fixed

- Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288))
- Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289))
- Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331))
- Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275))
- Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295))
- Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295))

## [3.0.18] - 2022-01-28

### Fixed

- Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232))
- Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252))

## [3.0.17] - 2022-01-26

### Fixed

- Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220))

## [3.0.16] - 2022-01-24

### Fixed

- Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080))
- Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118))
- Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
@dukex dukex mentioned this pull request Feb 15, 2022
Merged
dhh pushed a commit to rails/tailwindcss-rails that referenced this pull request Feb 19, 2022
@dukex
Update tailwindcss to v3.0.22 (#143)
0193dd7 
# CHANGELOG

## [3.0.22] - 2022-02-11

### Fixed

- Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424))

## [3.0.21] - 2022-02-10

### Fixed

- Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418))

## [3.0.20] - 2022-02-10

### Added

- Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412))

## [3.0.19] - 2022-02-07

### Fixed

- Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288))
- Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289))
- Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331))
- Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275))
- Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295))
- Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295))

## [3.0.18] - 2022-01-28

### Fixed

- Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232))
- Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252))

## [3.0.17] - 2022-01-26

### Fixed

- Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220))

## [3.0.16] - 2022-01-24

### Fixed

- Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080))
- Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118))
- Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
aisen-lopez pushed a commit to aisen-lopez/rails-tailwindcss-template that referenced this pull request Apr 1, 2022
Update tailwindcss to v3.0.22 (#143)
b598960 
# CHANGELOG

## [3.0.22] - 2022-02-11

### Fixed

- Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424))

## [3.0.21] - 2022-02-10

### Fixed

- Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418))

## [3.0.20] - 2022-02-10

### Added

- Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412))

## [3.0.19] - 2022-02-07

### Fixed

- Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288))
- Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289))
- Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331))
- Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275))
- Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295))
- Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295))

## [3.0.18] - 2022-01-28

### Fixed

- Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232))
- Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252))

## [3.0.17] - 2022-01-26

### Fixed

- Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220))

## [3.0.16] - 2022-01-24

### Fixed

- Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080))
- Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118))
- Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
anderscain63 added a commit to anderscain63/tailwindcss-rails that referenced this pull request Dec 20, 2022
@anderscain63
Update tailwindcss to v3.0.22 (#143)
c15f6d0 
# CHANGELOG

## [3.0.22] - 2022-02-11

### Fixed

- Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424))

## [3.0.21] - 2022-02-10

### Fixed

- Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418))

## [3.0.20] - 2022-02-10

### Added

- Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412))

## [3.0.19] - 2022-02-07

### Fixed

- Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288))
- Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289))
- Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331))
- Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275))
- Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295))
- Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295))

## [3.0.18] - 2022-01-28

### Fixed

- Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232))
- Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252))

## [3.0.17] - 2022-01-26

### Fixed

- Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220))

## [3.0.16] - 2022-01-24

### Fixed

- Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080))
- Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118))
- Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
titan2gman added a commit to titan2gman/tailwindcss-rails that referenced this pull request Dec 27, 2022
@titan2gman
Update tailwindcss to v3.0.22 (#143)
f87d60b 
# CHANGELOG

## [3.0.22] - 2022-02-11

### Fixed

- Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424))

## [3.0.21] - 2022-02-10

### Fixed

- Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418))

## [3.0.20] - 2022-02-10

### Added

- Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412))

## [3.0.19] - 2022-02-07

### Fixed

- Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288))
- Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289))
- Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331))
- Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275))
- Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295))
- Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295))

## [3.0.18] - 2022-01-28

### Fixed

- Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232))
- Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252))

## [3.0.17] - 2022-01-26

### Fixed

- Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220))

## [3.0.16] - 2022-01-24

### Fixed

- Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080))
- Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118))
- Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
smartech7 pushed a commit to smartech7/rails-tailwind-css that referenced this pull request Aug 4, 2023
@dukex
Update tailwindcss to v3.0.22 (#143)
35f284e 
# CHANGELOG

## [3.0.22] - 2022-02-11

### Fixed

- Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424))

## [3.0.21] - 2022-02-10

### Fixed

- Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418))

## [3.0.20] - 2022-02-10

### Added

- Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412))

## [3.0.19] - 2022-02-07

### Fixed

- Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288))
- Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289))
- Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331))
- Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275))
- Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295))
- Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295))

## [3.0.18] - 2022-01-28

### Fixed

- Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232))
- Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252))

## [3.0.17] - 2022-01-26

### Fixed

- Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220))

## [3.0.16] - 2022-01-24

### Fixed

- Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080))
- Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118))
- Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
RabbitDev810 pushed a commit to RabbitDev810/tailwind-rails that referenced this pull request Jan 22, 2024
@dukex
Update tailwindcss to v3.0.22 (#143)
5991543 
# CHANGELOG

## [3.0.22] - 2022-02-11

### Fixed

- Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424))

## [3.0.21] - 2022-02-10

### Fixed

- Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418))

## [3.0.20] - 2022-02-10

### Added

- Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412))

## [3.0.19] - 2022-02-07

### Fixed

- Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288))
- Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289))
- Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331))
- Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275))
- Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295))
- Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295))

## [3.0.18] - 2022-01-28

### Fixed

- Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232))
- Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252))

## [3.0.17] - 2022-01-26

### Fixed

- Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220))

## [3.0.16] - 2022-01-24

### Fixed

- Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080))
- Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118))
- Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RobinMalfait @dargmuesli @thecrypticace