Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cosmiconfig with lilconfig #6038

Merged
merged 3 commits into from Mar 1, 2022
Merged

Conversation

TrySound
Copy link
Contributor

It's already replaced in postcss-load-config

See https://github.com/postcss/postcss-load-config/blob/main/package.json#L26

@adamwathan
Copy link
Member

Hey sorry any chance you could rebase this to resolve the conflicts? Then can definitely merge 👍🏻 Thank you!

@TrySound
Copy link
Contributor Author

Hey, will rebase in a couple of hours! Btw having more ideas how to improve install size.

@TrySound
Copy link
Contributor Author

Done

@bradlc bradlc self-assigned this Mar 1, 2022
@bradlc
Copy link
Contributor

bradlc commented Mar 1, 2022

Hey @TrySound, thanks for updating the PR! What's the reason for updating the postcss version in package.json?

@thecrypticace
Copy link
Contributor

it probably happened automatically and wasn't noticed. NPM is doing the same thing for me any time I npm install a new dependency into the tailwindcss repo. I have absolutely no idea why.

@TrySound
Copy link
Contributor Author

TrySound commented Mar 1, 2022

yeah, npm does a bad job with lockfiles. Yarn and pnpm are more stable.

@bradlc
Copy link
Contributor

bradlc commented Mar 1, 2022

Ah I see, all good 👍 Thanks again!

@bradlc bradlc merged commit f31c4ee into tailwindlabs:master Mar 1, 2022
@MichaelDeBoey
Copy link
Contributor

@adamwathan @bradlc This would be a breaking change, as files without an extension are now handled differently
https://github.com/antonk52/lilconfig#difference-to-cosmiconfig

Schermafbeelding 2022-03-06 om 22 06 54

@TrySound
Copy link
Contributor Author

TrySound commented Mar 6, 2022

postcss-load-config migrated in 3.1.

@MichaelDeBoey
Copy link
Contributor

@TrySound They provide the yaml loaders themselves instead, so for them it's not breaking at all

Since we don't do that in this PR, it's a breaking change for Tailwind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants