Improve @apply performance #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't had a chance to look at this in depth yet but just wanted to follow up anyways and say thank you! We don't get PRs that touch stuff this deep very often so I really appreciate you digging in 🙏 Will get to this soon! |
|
Thanks for this, will try to get it out in a patch soon! |
adamwathan
pushed a commit
that referenced
this pull request
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3717
This is an attempt to improve the performance of using
@apply.As you can see on this profile, a lot of time is wasted on the
buildUtilityMapfunction.This PR tries to reduce the work done by this function by memoizing the static part
You can see the difference with this profile (with this patch applied)