Resolve broken relative logo sources on npmjs (relative → absolute) #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thank you for your PR! Very odd, we used relative URLs before as well 🤔 |
|
@RobinMalfait It appears the relative links work on npmjs for Probably worth opening a ticket on And… there |
|
Btw it appears that npmjs has since fixed that issue, so the correct logo displays for both light and dark mode, at least AFAICT when checking locally
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RobinMalfait Looks like that last PR caused a slight regression on npmjs where the logo is completely broken now, because it registers the
sourceURLs as relative links instead of absolute links.You can see that bug here: https://www.npmjs.com/package/tailwindcss
Before and after this PR (assuming this works 🤷🏻♂️… it should)
Unfortunately, npmjs doesn't yet have a dark mode of their own, so even after corrected, the logo will be mostly invisible on their site unless a stroke or some other sort of style is added to the logo to add contrast between the white text and white background.