Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow improvements #9609

Merged
merged 6 commits into from Oct 20, 2022
Merged

Workflow improvements #9609

merged 6 commits into from Oct 20, 2022

Conversation

RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented Oct 19, 2022 •
edited

This PR adds a few workflow improvements.

  • Dropped download links for the draft release (GitHub already adds them)
  • Separate test and lint
  • Create dedicated lint job (so that it only executes once)
  • Drop the pretier-plugin-tailwindcss for now
  • Our plugin is awesome, but it always runs an older version of Tailwind CSS (the one it is coupled with). If Tailwind is a dependency it will use that version instead. However we can't rely on that because the node/npm versions we use don't support that well. Meaning, the moment we drop support for those old versions we will add it immediately.

@RobinMalfait
remove unnecessary download links
09213f9 
GitHub already shows them in a table right below it.
@RobinMalfait
detach npm run style from npm run test
1c6030c
@RobinMalfait
decouple lint from test in workflows
205a784 
Which means that we don't need to do the crazy linking in certain
workflows.
@RobinMalfait
hoist the CI environment variable
0f6aed2
@RobinMalfait
create dedicated lint job
4baa63d 
The `lint` tests will run against source files and should not be
dependant on a specific node version. Instead of running the `npm run
style` on every node version we use, we can and should only run it once.
@RobinMalfait
remove prettier-plugin-tailwindcss
e8ad7d3 
As long as we use older versions of node/npm where we can't have
ourselves as a dependency, it is a bit of a mess to maintain properly
sorted html in tests.

Let's remove it for now until we have a better solution!
@RobinMalfait RobinMalfait changed the title [WIP] Workflow improvements Workflow improvements Oct 20, 2022
@RobinMalfait RobinMalfait merged commit 3c7fc69 into master Oct 20, 2022
@RobinMalfait RobinMalfait deleted the fix/workflow-improvements branch October 20, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RobinMalfait