Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations get purged if using step-start or step-end timing function #4791

Closed
timkley opened this issue Jun 24, 2021 · 2 comments · Fixed by #4795
Closed

Animations get purged if using step-start or step-end timing function #4791

timkley opened this issue Jun 24, 2021 · 2 comments · Fixed by #4795

Comments

@timkley
Copy link
Contributor

timkley commented Jun 24, 2021

What version of Tailwind CSS are you using?

v2.2.2

What build tool (or framework if it abstracts the build tool) are you using?

@symfony/webpack-encore": ^1.3.0

What version of Node.js are you using?

v12.0.0

What browser are you using?

N/A

What operating system are you using?

macOS

Reproduction repository

https://play.tailwindcss.com/P8QHN8mDNy?file=config

Describe your issue

When using step-start or step-end as animation-timing-function (see MDN for possible built in values) the animation won't work because parseAnimationValue won't return anything.

I'd be happy to provide a PR to fix this 👍🏻

@hug963
Copy link

hug963 commented Jun 24, 2021

Seems to be same issue as #4737

@timkley
Copy link
Contributor Author

timkley commented Jun 24, 2021

@hug963 I saw your issue and I think it's kinda related. In case of step-start / step-end it should be as easy as updating the timings constant and add those values: https://github.com/tailwindlabs/tailwindcss/blob/master/src/util/parseAnimationValue.js#L5

Your case needs to be handled a little different, I'd expect a new regex needs to be added to the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants