Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only variant #3136

Closed
weaversam8 opened this issue Dec 19, 2020 · 6 comments · Fixed by #4102
Closed

Read only variant #3136

weaversam8 opened this issue Dec 19, 2020 · 6 comments · Fixed by #4102

Comments

@weaversam8
Copy link

There's currently no variant for <input> elements with the readonly attribute. I added this myself today following the variant plugin documentation, but wanted to check whether this would be a good inclusion to the framework as a variant users can turn on.

Thoughts? If it's a good fit, I can probably do a PR relatively quickly.

@adamwathan
Copy link
Member

Hey! No concrete plans to add this but since we already have disabled I suppose there's no reason to close a PR for it, especially since it would be disabled by default. Feel free to open a PR for it if you like 👍🏻 Closing this though as we only use issues for bug reports.

@TheCatLady
Copy link

@weaversam8 Are you still willing to submit a PR to add the readonly variant? I would personally love to see this!

@weaversam8
Copy link
Author

weaversam8 commented Mar 22, 2021

@TheCatLady @skyporter @mendz - I actually no longer have the bandwidth to do this PR right now, sorry 😢

If anyone else wants to tackle this, it probably isn't too hard. Some reference PRs you can take a look at are #3298, #2385, and #1824.

@ghost ghost mentioned this issue Apr 18, 2021
@jhubbardsf
Copy link

Still an issue. Might tackle it this weekend if nothing else is pressing.

@RobinMalfait
Copy link
Contributor

@jhubbardsf we have a read-only variant: https://tailwindcss.com/docs/hover-focus-and-other-states#read-only

@jhubbardsf
Copy link

Oh, my bad. I was on a work call while reading through this and completely missed it. Figured out the issue was something else in the app now that I see this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants