Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailwindcss CLI v1.3 now requires Node v10 #1604

Closed
bradlc opened this issue Apr 22, 2020 · 3 comments
Closed

tailwindcss CLI v1.3 now requires Node v10 #1604

bradlc opened this issue Apr 22, 2020 · 3 comments

Comments

@bradlc
Copy link
Contributor

bradlc commented Apr 22, 2020

Because of the fs-extra bump the tailwindcss command now requires Node v10, as that module dropped support for Node versions prior to that.

The specific error I am seeing (on Node v8.12.0) is due to the usage of the optional catch binding feature added in Node v10:

> tailwindcss build in.css -o out.css

node_modules/fs-extra/lib/mkdirs/make-dir.js:86
      } catch {
              ^

SyntaxError: Unexpected token {

I'm guessing this was unintentional since it isn't mentioned in the release notes and it would constitute a breaking change. I propose reverting the fs-extra bump to maintain the original Node support until at least the next major Tailwind release.

@adamwathan
Copy link
Member

What do you think of the opinion here that changing language requirements doesn't constitute a new major release?

https://sebastiandedeyne.com/composer-semver-and-underlying-dependency-changes/

I would love to just drop support for Node 8 since it is end-of-life but I don't want to tag 2.0 because of it either. I also don't want dependabot to constantly be nagging me about outdated dependencies by locking to an older version, like it is currently doing to me with Prettier 😅

@bradlc
Copy link
Contributor Author

bradlc commented Apr 22, 2020

I think the key difference there is in this paragraph:

When you run composer update from a php:^7.2 environment, it won't pull in packages that require php:^7.4. Composer will keep requiring my/package:1.0.0 until my/package:1.0.1 is compatible with your project. Nothing's broken, you just won't be receiving any new updates.

As far as I'm aware this is not the case with Node/npm. If I'm running Node v8 it'll happily update tailwindcss to v1.3.4, and the CLI won't work anymore.

In composer-land I can get on board with that idea, but in this case I personally think it's a breaking change for sure, because Node/npm doesn't have the same behaviour.

@adamwathan
Copy link
Member

Fixed in 1.3.5, thanks Brad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants