Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prose elements legacy mode. Fixes #258 #259

Merged
merged 3 commits into from Mar 25, 2022

Conversation

Folyd
Copy link
Contributor

@Folyd Folyd commented Mar 22, 2022

I try to fix #258, not sure it is the correct way right now.

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tailwindlabs/tailwindcss-typography/HwaaCQDie9cXf3WMrp2LisZ2eG8M
✅ Preview: https://tailwindcss-typography-git-fork-folyd-fix-p-979bfc-tailwindlabs.vercel.app

@thecrypticace
Copy link
Contributor

Thanks for the PR! 🎉

It was almost there. Instead of an empty selector we needed to use & ${selector} to populate it properly. Otherwise the check was in the right spot. Thanks again!

@Folyd Folyd deleted the fix-prose-elements-legacy branch March 28, 2022 08:06
@tylerhunt
Copy link

This still isn't quite right. While it works for h1, it doesn't work for h2, h3, etc. Presumably this is because the selector ends up being & h1, h2, h3, h4, h5, h6 instead of & h1, & h2, & h3, & h4, & h5, & h6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

legacy mode not working for prose-{element} modifiers
3 participants