Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-controls removed from Disclosure.Button when using static on Disclosure.Panel #1741

Closed
Bjodol opened this issue Aug 5, 2022 · 1 comment · Fixed by #1747
Closed
Assignees

Comments

@Bjodol
Copy link

Bjodol commented Aug 5, 2022

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v1.6.6

What browser are you using?

Edge, Chrome

Reproduction URL

https://github.com/Bjodol/headless-ui-disclosure-bug

Describe your issue

When using the <Disclosure> component along with <Disclosure.Panel static> - Note the static - The aria-controls attribute is removed from the <Disclosure.Button> element. This is relevant in cases where you want to animate the content entry and exit without being able to do so with the Transition component. Example of this is you want to use animate height with react-animate-height

@RobinMalfait
Copy link
Collaborator

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should be fixed by #1747, and will be available in the next release.

You can already try it using npm install @headlessui/react@insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants