Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable go generate and staticcheck CI #4194

Closed
maisem opened this issue Mar 17, 2022 · 1 comment
Closed

Re-enable go generate and staticcheck CI #4194

maisem opened this issue Mar 17, 2022 · 1 comment
Assignees
@maisem
Labels
needs-fix

Comments

@maisem
Copy link
Collaborator

maisem commented Mar 17, 2022 •
edited

go generate fails because of golang/go#51629
staticcheck fails because of dominikh/go-tools#1166
@maisem maisem mentioned this issue Mar 17, 2022
Merged
@maisem maisem self-assigned this Mar 17, 2022
danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
8149066 
Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
@danderson danderson mentioned this issue Mar 17, 2022
Merged
danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
e49cd0b 
honk
Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
5b5a6a0 
Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
@danderson
Copy link
Member

One more upstream bug that breaks cmd/cloner: golang/go#51629

danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
cbcd4b7 
Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
d1d49f8 
Incidentally, simplify the go generate CI workflow, by
marking the dnsfallback update non-hermetic (so CI will
skip it) rather than manually filter it out of `go list`.

Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
62e4bb6 
Incidentally, simplify the go generate CI workflow, by
marking the dnsfallback update non-hermetic (so CI will
skip it) rather than manually filter it out of `go list`.

Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
e6d2f61 
Incidentally, simplify the go generate CI workflow, by
marking the dnsfallback update non-hermetic (so CI will
skip it) rather than manually filter it out of `go list`.

Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
danderson added a commit that referenced this issue Mar 17, 2022
@danderson
.github/workflows: work around golang/go#51629
6979793 
Incidentally, simplify the go generate CI workflow, by
marking the dnsfallback update non-hermetic (so CI will
skip it) rather than manually filter it out of `go list`.

Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
danderson added a commit that referenced this issue Mar 18, 2022
@danderson
.github/workflows: work around golang/go#51629
2a412ac 
Incidentally, simplify the go generate CI workflow, by
marking the dnsfallback update non-hermetic (so CI will
skip it) rather than manually filter it out of `go list`.

Updates #4194

Signed-off-by: David Anderson <danderson@tailscale.com>
maisem added a commit that referenced this issue Apr 5, 2022
@maisem
go.mod: bump staticcheck
6b55608 
Updates #4194

Signed-off-by: Maisem Ali <maisem@tailscale.com>
@maisem maisem mentioned this issue Apr 5, 2022
Merged
maisem added a commit that referenced this issue Apr 5, 2022
@maisem
go.mod: bump staticcheck (#4359)
ac2033d 
Updates #4194

Signed-off-by: Maisem Ali <maisem@tailscale.com>
bradfitz added a commit that referenced this issue Apr 13, 2022
@bradfitz
go.mod: bump x/tools for go/packages generics fix
86da51f 
Updates #4194

Change-Id: Ia992ffb14210d5ad53f8f98d12b80d64080998e6
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Apr 13, 2022
@bradfitz
Revert ".github/workflows: work around golang/go#51629"
04cbed6 
This reverts commit 2a412ac.

Updates #4194
bradfitz added a commit that referenced this issue Apr 13, 2022
@bradfitz
Revert ".github/workflows: work around golang/go#51629"
bf880c3 
This reverts commit 2a412ac.

Updates #4194

Change-Id: I0098b66b71d20bea301ca79058c1cdd201237dd0
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Apr 13, 2022
@bradfitz
go.mod: bump x/tools for go/packages generics fix
09c5c9e 
Updates #4194

Change-Id: Ia992ffb14210d5ad53f8f98d12b80d64080998e6
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Apr 13, 2022
@bradfitz
Revert ".github/workflows: work around golang/go#51629"
a49d8d5 
This reverts commit 2a412ac.

Updates #4194

Change-Id: I0098b66b71d20bea301ca79058c1cdd201237dd0
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@maisem maisem closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maisem maisem

Labels
needs-fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danderson @DentonGentry @maisem