Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipnlocal: panic due to missing health.Tracker when migrating prefs #11986

Closed
andrew-d opened this issue May 3, 2024 · 1 comment
Closed

ipnlocal: panic due to missing health.Tracker when migrating prefs #11986

andrew-d opened this issue May 3, 2024 · 1 comment

Comments

@andrew-d
Copy link
Member

andrew-d commented May 3, 2024

Observed here: https://github.com/tailscale/tailscale/actions/runs/8940541217/job/24558866819?pr=11985

## WARNING: (non-fatal) nil health.Tracker (being strict in CI):
goroutine 25 [running]:
tailscale.com/health.(*Tracker).nil(0x0)
	tailscale.com/health/health.go:185 +0x79
tailscale.com/health.(*Tracker).SetCheckForUpdates(0x0, 0x1)
	tailscale.com/health/health.go:571 +0x33
tailscale.com/ipn/ipnlocal.(*profileManager).updateHealth(...)
	tailscale.com/ipn/ipnlocal/profiles.go:450
tailscale.com/ipn/ipnlocal.(*profileManager).NewProfile(0x9e54060)
	tailscale.com/ipn/ipnlocal/profiles.go:459 +0x82
tailscale.com/ipn/ipnlocal.(*profileManager).migrateFromLegacyPrefs(0x9e54060)
	tailscale.com/ipn/ipnlocal/profiles.go:592 +0x50
tailscale.com/ipn/ipnlocal.newProfileManagerWithGOOS({0x8d59f88, 0x9e54030}, 0x9dbd1a0, {0x9c44223, 0x5})
	tailscale.com/ipn/ipnlocal/profiles.go:580 +0x1c9
tailscale.com/ipn/ipnlocal.NewLocalBackend(0x9dbd1a0, {0xb3, 0xfa, 0x9, 0x58, 0xa6, 0x77, 0x17, 0x4, 0x7a, ...}, ...)
	tailscale.com/ipn/ipnlocal/local.go:367 +0x154
main.getLocalBackend({0x8d5dec0, 0x9e54210}, 0x9dbd1a0, {0xb3, 0xfa, 0x9, 0x58, 0xa6, 0x77, 0x17, ...}, ...)
	tailscale.com/cmd/tailscaled
@andrew-d
Copy link
Member Author

andrew-d commented May 3, 2024

cc @bradfitz

andrew-d added a commit that referenced this issue May 3, 2024
@andrew-d
ipn/ipnlocal: plumb health.Tracker into profileManager constructor
692a1d8 
Setting the field after-the-fact wasn't working because we could migrate
prefs on creation, which would set health status for auto updates.

Updates #11986

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
Change-Id: I41d79ebd61d64829a3a9e70586ce56f62d24ccfd
@andrew-d andrew-d mentioned this issue May 3, 2024
Merged
bradfitz pushed a commit that referenced this issue May 3, 2024
@andrew-d @bradfitz
ipn/ipnlocal: plumb health.Tracker into profileManager constructor
e9505e5 
Setting the field after-the-fact wasn't working because we could migrate
prefs on creation, which would set health status for auto updates.

Updates #11986

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
Change-Id: I41d79ebd61d64829a3a9e70586ce56f62d24ccfd
@bradfitz bradfitz closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradfitz @andrew-d