Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: NoLogsNoSupport and CapabilityDataPlaneAuditLogs should not set WantRunning = false #11793

Open
j-licht opened this issue Apr 18, 2024 · 0 comments · May be fixed by #11825
Open

FR: NoLogsNoSupport and CapabilityDataPlaneAuditLogs should not set WantRunning = false #11793

j-licht opened this issue Apr 18, 2024 · 0 comments · May be fixed by #11825
Labels
fr Feature request needs-triage

Comments

@j-licht
Copy link

j-licht commented Apr 18, 2024

What are you trying to do?

We enabled the new Network flow logs in our tailnet and then we lost the half of our devices.
Unfortunately, they all had the NoLogsNoSupport knob set, as we used them before with our headscale.
Then the devices got the "tailnet requires logging to be enabled. Remove --no-logs-no-support from tailscaled command line." Error message and also set the WantRunning state to false.

After we noticed the Issue, we disabled the Network log again, but the devices still don't reconnect.

How should we solve this?

I would suggest something in the client to do an reconnect if the CapabilityDataPlaneAuditLogs disappears again.

What is the impact of not solving this?

Now we need to get access on other ways to reenable tailscale.

Anything else?

tailscale/ipn/ipnlocal/local.go

Line 1223 in 03d5d1f

prefs.WantRunning = false

@j-licht j-licht added fr Feature request needs-triage labels Apr 18, 2024
bradfitz added a commit that referenced this issue Apr 20, 2024
@bradfitz
ipn/ipnlocal, control/controlclient: keep map poll alive on NoLogsNoS…
d37674a 
…upport + flow logs

Fixes #11793

Change-Id: I77eab157b6be24799805ece905855b6fecfa91c9
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz linked a pull request Apr 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fr Feature request needs-triage
Projects
None yet
Milestone
No milestone
1 participant
@j-licht