Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Waking up Parser<P, S> FSM #45

Open
KodrAus opened this issue Jun 28, 2016 · 1 comment
Open

Error Waking up Parser<P, S> FSM #45

KodrAus opened this issue Jun 28, 2016 · 1 comment

Comments

@KodrAus
Copy link

KodrAus commented Jun 28, 2016

I'm absolutely positive I'm doing this wrong; I have a rotor_http::client::Persistent<P, S> machine, which wraps rotor_http::client::Parser<P, S>.

If I use a Notifier to wake up my fsm while a request is active, I get a panic in the Parser and everything blows up. The source of the panic is this line in the Parser wrapper:

https://github.com/tailhook/rotor-http/blob/master/src/client/parser.rs#L576

So if I shouldn't be waking up my fsm while it's already busy, how can I avoid calling wakeup in code that doesn't know what that machine is up to? I would've thought you could just ignore wakeup on a busy machine, because it's already awake?

@tailhook
Copy link
Owner

Well, the unimplemented always means we have not done this stuff yet. Not that you're doing it wrong.

Since there is wakeup handler in Requester it seems to be easy to fix. Do you want to do a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants