Add compatibility with 'deny(rust_2018_idioms)' #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In crates with #![forbid|deny(rust_2018_idioms)] the code generated by the quick_error macro will now cause linter errors. This commit turns these on in the crate itself and fixes them in two ways: * blanket #[allow(unused)] was replaced with a more specific version * the lifetime in std::fmt::Formatter types is declareed
|
Looks good. But please submit PR without whitespace changes. |
Thank you, `git checkout HEAD~1 -p`
|
Sorry for that, 'format on save' is your friend until it isn't 🤦♂️. I also tried, without success, to prevent rustfmt from touching the entire file and failed. That was a surprisingly unpolished experience or I shouldn't try such preposterous things early in the morning 😅. |
|
Merged. Thanks! |
|
Released as v2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crates with
#![forbid|deny(rust_2018_idioms)]the code generated by the quick_error macro will now cause linter errors.This commit turns these on in the crate itself and fixes them in two ways:
#[allow(unused)]was replaced with a more specific versionI hope a new patch release could be made if merging this PR is possible :).