Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support just and dprint #33

Closed
azzamsa opened this issue Dec 20, 2022 · 5 comments · Fixed by #34
Closed

Support just and dprint #33

azzamsa opened this issue Dec 20, 2022 · 5 comments · Fixed by #34
Labels
enhancement New feature or request

Comments

@azzamsa
Copy link

azzamsa commented Dec 20, 2022

Hi.

I have been using install-action across my project's CI. Most of them are just and dprint.

Would you like to support just and dprint?
Is falling back to binstall took longer than built-in support crates?

Thanks a lot for insall-action ❤️

@NobodyXu
Copy link
Collaborator

Is falling back to binstall took longer than built-in support crates?

It might take a bit longer, but I think it's noticeable since building on GHA takes much longer than that.
Besides, GHA has excellent network so downloading is not going to be the bottleneck.

@taiki-e
Copy link
Owner

taiki-e commented Dec 22, 2022

#27's automatic update mechanism greatly reduces the cost of supporting new tools, so I'm fine to support these once #27 is merged. (I hope to be able to merge it this weekend...)

@taiki-e taiki-e added the enhancement New feature or request label Dec 24, 2022
@taiki-e taiki-e changed the title Support dprint Support just and dprint Dec 24, 2022
@azzamsa
Copy link
Author

azzamsa commented Dec 25, 2022

@taiki-e It doesn't work in my side. Do we need to wait for some time? Maybe Github doesn't pick up the latest commit or should I wait for a new release?

From 1660e22a2fdabc6945e0920751723afc639a3815 Mon Sep 17 00:00:00 2001
From: azzamsa <me@azzamsa.com>
Date: Sun, 25 Dec 2022 21:09:01 +0700
Subject: [PATCH] ci: `install-action` finally supports just & dprint

Out of the box.
---
 .github/workflows/ci.yaml | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 724454b..79eb953 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -19,14 +19,10 @@ jobs:
           components: clippy, rustfmt
 
       - name: Install latest just release
-        uses: taiki-e/install-action@v1
-        with:
-          tool: just
+        uses: taiki-e/install-action@just
 
       - name: Install latest dprint release
-        uses: taiki-e/install-action@v1
-        with:
-          tool: dprint
+        uses: taiki-e/install-action@dprint
 
       # - name: Cache
       #   uses: Swatinem/rust-cache@v2
@@ -56,9 +52,7 @@ jobs:
         uses: taiki-e/install-action@nextest
 
       - name: Install latest just release
-        uses: taiki-e/install-action@v1
-        with:
-          tool: just
+        uses: taiki-e/install-action@just
 
       - name: Cache
         uses: Swatinem/rust-cache@v2
 Prepare all required actions
Getting action download info
Error: Unable to resolve action `taiki-e/install-action@dprint`, unable to find version `dprint`. Unable to resolve action `taiki-e/install-action@just`, unable to find version `just`

@taiki-e
Copy link
Owner

taiki-e commented Dec 25, 2022

Published in 2.0.0.

should I wait for a new release?

Yeah, the @<tool> shorthand will not work until the first release of official support.
I now created a new release so it should now work.

@azzamsa
Copy link
Author

azzamsa commented Dec 25, 2022

Worked like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants