Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Trunk #129

Closed
wants to merge 1 commit into from
Closed

Support Trunk #129

wants to merge 1 commit into from

Conversation

azzamsa
Copy link

@azzamsa azzamsa commented Jun 7, 2023

Fixes #128

@taiki-e I don't have a clue on where to get the manifest/trunk.json

@NobodyXu

This comment was marked as outdated.

Sign in to view
NobodyXu
NobodyXu requested changes Jun 8, 2023
View reviewed changes
tools/codegen/base/trunk.json Outdated Show resolved Hide resolved
tools/codegen/base/trunk.json Outdated Show resolved Hide resolved
tools/codegen/base/trunk.json Show resolved Hide resolved
@azzamsa
Copy link
Author

azzamsa commented Jun 8, 2023 •
edited

It runs but doesn't generate the manifest.

⬢ ❯ ./tools/manifest.sh trunk 0.16.0
    Finished release [optimized] target(s) in 0.04s
     Running `target/release/install-action-internal-codegen trunk 0.16.0`
downloading releases of https://github.com/thedodd/trunk from https://api.github.com/repos/thedodd/trunk/releases
update manifest for versions '=0.16.0'
no asset '["trunk-x86_64-unknown-linux-musl.tar.gz"]' for host platform 'x86_64_linux_musl'
downloading https://github.com/thedodd/trunk/releases/download/v0.16.0/trunk-x86_64-apple-darwin.tar.gz for checksum...
  downloaded complete
getting sha256 hash for https://github.com/thedodd/trunk/releases/download/v0.16.0/trunk-x86_64-apple-darwin.tar.gz
0638206b8b3bd27a92b2dd252cca0560e01c8351755d6212a3278ac0047b58b5 *trunk-x86_64-apple-darwin.tar.gz
downloading https://github.com/thedodd/trunk/releases/download/v0.16.0/trunk-x86_64-pc-windows-msvc.zip for checksum...
 downloaded complete
getting sha256 hash for https://github.com/thedodd/trunk/releases/download/v0.16.0/trunk-x86_64-pc-windows-msvc.zip
0febcccfa58cd5e62eacd8a934ef6967f845a0a01ef7e42cecdf50348a309b5e *trunk-x86_64-pc-windows-msvc.zip
no asset '["trunk-aarch64-unknown-linux-musl.tar.gz"]' for host platform 'aarch64_linux_musl'
no asset '["trunk-aarch64-apple-darwin.tar.gz"]' for host platform 'aarch64_macos'
Error: platform list in base manifest for trunk contains x86_64_linux_musl, but latest release (0.16.0) doesn't contain it

NobodyXu
NobodyXu requested changes Jun 8, 2023
View reviewed changes
tools/codegen/base/trunk.json Outdated Show resolved Hide resolved
tools/codegen/base/trunk.json Outdated Show resolved Hide resolved
tools/codegen/base/trunk.json Outdated Show resolved Hide resolved
@azzamsa azzamsa force-pushed the support-trunk branch 2 times, most recently from 410b211 to 2b98276 Compare June 8, 2023 05:25
@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 8, 2023 •
edited

@azzamsa trunks pre-built seems to use glibc 2.29, while ubuntu 20.04 uses old glibc

@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 8, 2023

Alpine failed because trunk does not provide x86_64-unknown-linux-musl build.

@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 8, 2023

I think the best way to resolve this is for trunk to provide pre-built artifacts for musl and for install-action to also use musl artifacts on gnu targets.

@azzamsa
Copy link
Author

azzamsa commented Jun 8, 2023

I think the best way to resolve this is for trunk to provide pre-built artifacts for musl and for install-action to also use musl artifacts on gnu targets.

You mean, we need to convince (or make a PR) to Trunk to include musl target in the release?

@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 8, 2023

I think the best way to resolve this is for trunk to provide pre-built artifacts for musl and for install-action to also use musl artifacts on gnu targets.

You mean, we need to convince (or make a PR) to Trunk to include musl target in the release?

Yes, otherwise it won't work on Alpine.
I recommend either installing musl-tools or use cargo-zigbuild to achieve this, the latter also support cross compiling to armv7/aarch64 linux gnu/musl.

It would also be great if you can change their ci to use ubuntu-20.04, which will guarantee that their pre-built artifacts for x86_64-unknown-gnu can run on our CI.

@taiki-e taiki-e force-pushed the main branch 2 times, most recently from ffd4335 to 87c0891 Compare July 18, 2023 14:51
@azzamsa
Copy link
Author

azzamsa commented Oct 13, 2023

I don't think I can make Trunk compile in musl target.

@azzamsa azzamsa closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Trunk
2 participants
@azzamsa @NobodyXu