Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: force tags on files to match tags in the tag library #2049

Open
PaperOrb opened this issue Feb 9, 2024 · 2 comments
Open

Comments

@PaperOrb
Copy link

PaperOrb commented Feb 9, 2024

Currently, tags on files are not updated when you change their color in the tag library. The steps to reproduce this are:

  1. go to tag library
  2. click 3 dots on tag group
  3. edit tag group
  4. hit "change default tag background" and select a color
  5. hit "apply color changes to all tags in tag group" and hit "OK"

The problems with this current setup are as follows:

  1. tag1 in your tag library can be green while tag1 on file_1 to file_50 can be red. This has 0 benefit and just creates confusion. Example of mismatched tag colors.
  2. There's no way currently to update the color of tags on your files in bulk.

I'm seriously scratching my head at why this is expected behavior? It's so quirky that people even thought it was a bug in #1617. It makes no sense for the tag library pane to be "out of sync" with what the actual tags on your files are. I propose treating the tag library as a "single source of truth" for your tags rather than as the tag library just being its own detached thing.

@PaperOrb PaperOrb closed this as completed Feb 9, 2024
@PaperOrb PaperOrb reopened this Feb 9, 2024
@PaperOrb PaperOrb changed the title Tag colors aren't being updated Feature request: force tags to change color everywhere Feb 9, 2024
@PaperOrb PaperOrb changed the title Feature request: force tags to change color everywhere Feature request: force tags on files to match tags in the tag library Feb 9, 2024
@sytolk
Copy link
Member

sytolk commented Feb 12, 2024

Hi,
For this issue it's have two options:

  1. tag color assotiation to be written in app local storage tag_id => color; This way we can easy change color for all tags with this id downside is if we have shared folder and open it with an other Tagspaces installation -> tag color will be default.

  2. Currently Tagspaces write tag color in sidecar file like .ts/file_name.json this way if we open the same folder with other Tagspaces installation or just reinstall Tagspaces (or clear app data) the tag color will be the same. But thereby it's hard to change all tag colors - it's need to walkDirectory and change all json file with some tag. We have this script for metacleaner it's need to modify it to change tags instead. @uggrock ?

@PaperOrb
Copy link
Author

PaperOrb commented Feb 12, 2024

I don't have a preference because I'm on linux and can easily share all my tag spaces stuff if I need to use it in 2 places. Maybe that's harder for windows users though.

I do want to put an alert here that I opened a closely related but separate issue at #2053.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants