Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test requests per second part of record_request_metric() #393

Open
slashrsm opened this issue Nov 22, 2021 · 0 comments
Open

Test requests per second part of record_request_metric() #393

slashrsm opened this issue Nov 22, 2021 · 0 comments

Comments

@slashrsm
Copy link
Collaborator

slashrsm commented Nov 22, 2021

In order to reliably test this hunk we need to control the return value of Utc::now(). There is a pull request that allows that, but it is still in progress.

Until that is in we could add something on GooseAttack that would wrap Utc::now() and let us override it in tests. Not ideal since we would be polluting code with test-only logic.

This is a follow-up of #392.

EDIT: Also test GooseMetric::record_users_tasks_per_second(), which has the same problem. See #394 for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant