Remove use of const fn, add CI tests for MSRV

[dralley]

No description provided.

[codecov-commenter]

Codecov Report

Merging #481 (b8cdc1f) into master (da5f1e7) will decrease coverage by 0.14%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   54.17%   54.03%   -0.15%     
==========================================
  Files          30       30              
  Lines       12640    12662      +22     
==========================================
- Hits         6848     6842       -6     
- Misses       5792     5820      +28     

Flag	Coverage Δ
unittests	54.03% <93.10%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/name.rs	88.54% <75.00%> (ø)
src/reader/mod.rs	92.04% <83.33%> (ø)
src/de/escape.rs	21.05% <100.00%> (ø)
src/de/simple_type.rs	90.63% <100.00%> (ø)
src/encoding.rs	100.00% <100.00%> (ø)
src/escapei.rs	12.15% <100.00%> (-0.07%)	⬇️
src/events/attributes.rs	93.90% <100.00%> (ø)
src/events/mod.rs	72.88% <100.00%> (ø)
src/reader/parser.rs	98.62% <100.00%> (-0.69%)	⬇️
src/reader/slice_reader.rs	95.31% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[adamreichold]

Thanks for going the extra mile and making things work even for 1.54 instead of 1.56!

[Mingun]

So I think, that changes should be done:

• fix key in Cargo.toml
• set MSRV according to cargo check
• add a badge to readme

Also, maybe add a test for minimal versions? It seem that proper way to test it is using https://lib.rs/crates/cargo-minimal-versions.

Specifying dependencies with caret seems unnecessary, actually, their are already specified as caret dependencies. I think, that this part can be reverted if that will not fail the build.

Also, it seems that actually not all consts are unsupported on old rustc, maybe leave some of them? I don't insist, though.

[dralley]

set MSRV according to cargo check

I assume by this you mean: repeatedly downgrade the toolchain until cargo check doesn't work anymore? Or did you mean something else?

add a badge to readme

I looked around at other projects to see how it is typically done, and it actually seems rather uncommon. serde, tokio, hyper, axum, kube-rs, rustls, thiserror, opencv-rust, etc... none of them use it. I did find one for the regex crate, but looking at how the badge is configured compared to the others, I'm not sure that it's worth it.

[Mingun]

I assume by this you mean: repeatedly downgrade the toolchain until cargo check doesn't work anymore? Or did you mean something else?

I mean, do the same steps that you did to find MSRV as 1.54, but run cargo check instead of cargo check --all-features as, it seems, you did. You can also try https://github.com/foresterre/cargo-msrv

I did find one for the regex crate, but looking at how the badge is configured compared to the others, I'm not sure that it's worth it.

regex, serde, actix just output static version of badge (i. e. MSRV is encoded in the link) generated by shields.io. This is fine for us as well.

[dralley]

cargo-msrv said the minimum was 1.43.1, but I was having some issues with the MSRV check with that version due to the document-features dependency. I'm not quite sure what was going on with that.

But in any case it works fine if I bump it up a bit higher to 1.46.0.

[vojtechkral]

Hey guys, I ran into this, can I trouble you to tag a release with this fix? 🙏

[jonhoo]

Gentle nudge on this @Mingun — could we get a new release with this fix too?

[Mingun]

Yes, I'll make a release soon. Actually, I plan to make a new release after merging #490, but because it introduces some significant changes, it will be better to make a intermediate release with features, wanted by community now. After all, releases does not happen much

0.26.0 released.