You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interleaving calls to read_event and read_namespaced_event could lead to surprising behavior (internal stack of namespaces would not be properly maintained?). It seems the Reader should always be either tracking or not tracking the namespaces, and as such should expose some configuration fn parse_namespaces(self, parse: bool) -> Self. That, or perhaps there should be separate implementations, EventReader, NamespacedEventReader, with only the latter exposing fns such as read_namespaced_event.
The text was updated successfully, but these errors were encountered:
Yes, the current design of reading namespaces are not good. I'd prefer that namespace buffer would be in the Reader, because, unlike buffer for events, I cannot imagine why the user may want to clear it -- if he/she would do that, he/she lose all namespaces information and probably even breaks quick-xml.
PR for moving namespaces buffer inside Reader and always be aware of namespaces is welcome.
Interleaving calls to
read_event
andread_namespaced_event
could lead to surprising behavior (internal stack of namespaces would not be properly maintained?). It seems theReader
should always be either tracking or not tracking the namespaces, and as such should expose some configurationfn parse_namespaces(self, parse: bool) -> Self
. That, or perhaps there should be separate implementations,EventReader
,NamespacedEventReader
, with only the latter exposing fns such asread_namespaced_event
.The text was updated successfully, but these errors were encountered: