New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for XML Schema xs:list
type
#395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 60.79% 62.50% +1.71%
==========================================
Files 19 20 +1
Lines 9843 10664 +821
==========================================
+ Hits 5984 6666 +682
- Misses 3859 3998 +139
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
47689e4
to
8d5215a
Compare
I tried to do a code review on this PR but since I don't use quick-xml via serde, am not familiar with Serde's parsing, etc. I realized I don't have time to do all of that research, plus dig through the XML spec, plus review the PR, and keep everything in my head long enough to get it done. So I have just given this a brief look through. You've done a great job with the testing |
Feel free to merge this without a full approval |
failures (8): seq::fixed_name::fixed_size::xs_list::many seq::fixed_name::fixed_size::xs_list::one seq::fixed_name::variable_size::xs_list::many seq::fixed_name::variable_size::xs_list::one seq::variable_name::fixed_size::xs_list::many seq::variable_name::fixed_size::xs_list::one seq::variable_name::variable_size::xs_list::many seq::variable_name::variable_size::xs_list::one
This PR allows deserializing
Vec
and other sequences from space-separated lists, as defined by XML Schema specification. So now this is possible:Deserialize
from