{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":167349873,"defaultBranch":"vee-eight-lkgr","name":"node","ownerLogin":"szuend","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-01-24T10:34:25.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/325588?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1712295459.0","currentOid":""},"activityList":{"items":[{"before":"66345c02439f46e157a728fdf18a472011029444","after":"f79c3cb3fa9a9ec28dcf16f6ee0fe90dd5f1fc97","ref":"refs/heads/fix-inspector-string-view-usage","pushedAt":"2024-04-22T07:31:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"szuend","name":"Simon Zünd","path":"/szuend","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/325588?s=80&v=4"},"commit":{"message":"Rename function to ToV8Value and mirror std::string_view overload","shortMessageHtmlLink":"Rename function to ToV8Value and mirror std::string_view overload"}},{"before":"8d52133bc32c974cc8a921f61defedd031c76b7e","after":"66345c02439f46e157a728fdf18a472011029444","ref":"refs/heads/fix-inspector-string-view-usage","pushedAt":"2024-04-08T06:04:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"szuend","name":"Simon Zünd","path":"/szuend","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/325588?s=80&v=4"},"commit":{"message":"Rename function to ToV8Value and mirror std::string_view overload","shortMessageHtmlLink":"Rename function to ToV8Value and mirror std::string_view overload"}},{"before":"a4087c92c1b7b50adfd3faca83b686ae189e2631","after":"8d52133bc32c974cc8a921f61defedd031c76b7e","ref":"refs/heads/fix-inspector-string-view-usage","pushedAt":"2024-04-05T06:00:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"szuend","name":"Simon Zünd","path":"/szuend","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/325588?s=80&v=4"},"commit":{"message":"Apply linter","shortMessageHtmlLink":"Apply linter"}},{"before":"0d43fabd6fc635cca2a1c24397d1c3d9ddeadd60","after":"a4087c92c1b7b50adfd3faca83b686ae189e2631","ref":"refs/heads/fix-inspector-string-view-usage","pushedAt":"2024-04-05T05:43:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"szuend","name":"Simon Zünd","path":"/szuend","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/325588?s=80&v=4"},"commit":{"message":"src: fix inefficient usage of v8_inspector::StringView\n\nv8_inspector::StringView can either be one-byte or two-byte strings.\nNode has currently two places where it's unconditionally assumed that\nit's a two-byte StringView.\n\nThis requires the upstream V8 inspector to unnecessarily create\na copy of the string:\n\nhttps://source.chromium.org/chromium/chromium/src/+/main:v8/src/inspector/v8-inspector-session-impl.cc;l=192-199;drc=05bacd38e7a31e92afe0fd66081dfa2cc03b934a\n\nThis is particularly slow, especially for large CDP messages, as the\nserialized JSON is iterated 8-bit char by 8-bit char and each one\nwidened to a 16-bit char.\n\nThis PR introduces a small helper that correctly converts a StringView\nto a v8::String instance honoring the \"is8Bit\" flag. This allows\nupstream V8 to remove the unnecessary widening copy.","shortMessageHtmlLink":"src: fix inefficient usage of v8_inspector::StringView"}},{"before":null,"after":"0d43fabd6fc635cca2a1c24397d1c3d9ddeadd60","ref":"refs/heads/fix-inspector-string-view-usage","pushedAt":"2024-04-05T05:37:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"szuend","name":"Simon Zünd","path":"/szuend","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/325588?s=80&v=4"},"commit":{"message":"src: Fix inefficient usage of v8_inspector::StringView\n\nv8_inspector::StringView can either be one-byte or two-byte strings.\nNode has currently two places where it's unconditionally assumed that\nit's a two-byte StringView.\n\nThis requires the upstream V8 inspector to unnecessarily create\na copy of the string:\n\nhttps://source.chromium.org/chromium/chromium/src/+/main:v8/src/inspector/v8-inspector-session-impl.cc;l=192-199;drc=05bacd38e7a31e92afe0fd66081dfa2cc03b934a\n\nThis is particularly slow, especially for large CDP messages, as the\nserialized JSON is iterated 8-bit char by 8-bit char and each one\nwidened to a 16-bit char.\n\nThis PR introduces a small helper that correctly converts a StringView\nto a v8::String instance honoring the \"is8Bit\" flag. This allows\nupstream V8 to remove the unnecessary widening copy.","shortMessageHtmlLink":"src: Fix inefficient usage of v8_inspector::StringView"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAENrdP4AA","startCursor":null,"endCursor":null}},"title":"Activity · szuend/node"}