Always import classes #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…#107) (#121) * Setup the hook callback rule and test. * Add the wp-hooks library. * Start adding tests. * Preparing more tests. * If we don't have enough arguments, bail out and let PHPStan handle the error. * If the callback is not valid, bail out and let PHPStan handle the error: * Simplify this. * More valid test cases. * Update some test line numbers. * First pass at detecting mismatching accepted and expected argument counts. * Remove some accidental duplicates. * Fix some logic. * Let's split this up before it gets out of hand. * Reduce this down. * More tidying up. * We're going to be needing this in multiple methods soon. * Prep for callback return type checking, not yet functional. * Split action return type assertion into its own method. * Bring this message more inline with those used by PHPStan. * Add detection for filter callbacks with no return value. * Don't need this just yet. * Use early exit to reduce code nesting. * Remove unused imports. * Yoda comparisons are disallowed. * Coding standards. * Remove unused code. * Use early return to reduce code nesting. * Remove more unused code. * Renaming. * Use early return to reduce code nesting. * Tidying up. * Correct logic introduced during refactoring. * Exclude "maybe" callables. * More handling for parameter counts. * More handling for optional parameters in hook callbacks. * Make the tests more manageable. * Tests for more callback types. * Tidying up. * This isn't used. * More test cases. * Tests for variadic callbacks. * More specific handling for variadic callbacks. * More tests. * The hooks names are not relevant to the tests. * Remove an `else`. * I'm still not entirely sure why this works, but it does. Props @herndlm. * Another test for an action with a return value. * More variadic handling. * Turns out PHPStan handles typed and untyped functions differently. * Partly broken callbacks will trigger an error in PHPStan so we don't need to handle them. * Terminology. * Refactoring. * PHP 7.2 compatibility. * Reorder the processing so the return type is checked first. * More tests. Co-authored-by: Viktor Szépe <viktor@szepe.net> Co-authored-by: John Blackbourn <john@humanmade.com>
|
@herndlm Does this PR do any harm? |
|
sorry, only saw this now. this is only CS, right? no, I personally prefer to import everything, phpstan does too. you could enforce this via e.g. https://github.com/slevomat/coding-standard/blob/master/doc/namespaces.md#slevomatcodingstandardnamespacesreferenceusednamesonly- which we also use |
|
Thank you for your response. There is a simple rule: import everything + FQCN for docblocks and exceptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.