New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/clean-up installation instructions #114
Conversation
pip3 install says: WARNING: Discarding git+https://github.com/systemd/python-systemd.git#egg=systemd. Requested systemd-python from git+https://github.com/systemd/python-systemd.git#egg=systemd has inconsistent name: filename has 'systemd', but metadata has 'systemd-python' Closes systemd#97.
Bash doesn't do anything special for a command with '#', but at least zsh treat it as a comment. It's better to quote such a commandline.
README.md
Outdated
apt-get update | ||
apt-get install python3-systemd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apt-get update | |
apt-get install python3-systemd | |
apt update | |
apt install python3-systemd |
would be the more modern way of putting this, although I'd omit the apt update
. It will complain (nicely) if the sources are out of date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the problem that apt
isn't available everywhere yet? (I prefer it too, but I thought that apt-get
is more widely supported…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although I'd omit the apt update. It will complain (nicely) if the sources are out of date.
No, it doesn't:
$ podman run -it --rm debian
root@adad5c659058:/# apt install python3-systemd
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package python3-systemd
(And after apt update
, it works.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apt
is available in the stretch, which is the oldest listed release for it and stretch has already ended LTS support, so I don't think it's super relevant. There might of course still be super LTS stuff flying around, but I wouldn't think they are a relevant target audience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Fedora has no python2 package, so drop that. Similarly, with latest Debian and Opensuse, 'apt-get install python3-systemd' works, but 'apt-get install python-systemd' doesn't. (Tested with podman run -it --rm debian apt-get install python3-systemd mock -r opensuse-tumbleweed-x86_64 --enable-network -i python3-systemd) It also seems we never built the package in EPEL, so let's drop RHEL/CentOS from the list. If people need to, they can install from sources where the distro packages are unavailable (and they shouldn't be using python2 anyway at this point.) Also add 'apt-get update' into the instructions because w/o that install does not work in a pristine container. Fixes systemd#78.
Based on Jörg Behrmann's comment: systemd#114 (comment) > apt is available in the stretch, which is the oldest listed [1] release for it > and stretch has already ended LTS support. [1] https://packages.debian.org/bullseye/apt
No description provided.