Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: expand docs on meta theme-color #2134

Merged
merged 4 commits into from Mar 29, 2022
Merged

Conversation

hasparus
Copy link
Member

@hasparus hasparus commented Feb 15, 2022

I've expanded the docs on meta theme color to present some more alternatives.


Further reading: https://css-tricks.com/meta-theme-color-and-trickery/

@vercel
Copy link

vercel bot commented Feb 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/6swr4UNPe9uY6q1oSykmzi991qQT
✅ Preview: https://theme-ui-git-theme-color-misleading-systemui.vercel.app

@hasparus hasparus added the documentation Changes only affect the documentation label Feb 15, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c69043b:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

@lachlanjc
Copy link
Member

Does anybody actually want a blue browser top bar?

Uhhh yeah I do :)

Maybe we just clarify you can use any of your colors depending on how bold a look you want?

@hasparus
Copy link
Member Author

Uhhh yeah I do :)

you monster xD

Maybe we just clarify you can use any of your colors depending on how bold a look you want?

Definitely. I'll go back to it and try writing something more informative here.

@hasparus hasparus changed the title docs: stop advising people to use primary as theme-color docs: expand docs on meta theme-color Mar 21, 2022
Co-authored-by: Lachlan Campbell <lachlanjc@hey.com>
Co-authored-by: Lachlan Campbell <lachlanjc@hey.com>
@lachlanjc lachlanjc merged commit f005a92 into develop Mar 29, 2022
@lachlanjc lachlanjc deleted the theme-color-misleading branch March 29, 2022 06:32
@hasparus hasparus added the prerelease This change is available in a prerelease. label Mar 31, 2022
@hasparus
Copy link
Member Author

🚀 PR was released in v0.14.2 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants