Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color-modes): Warn when theme color keys have leading/trailing whitespace #2099

Merged
merged 1 commit into from Jan 29, 2022

Conversation

lachlanjc
Copy link
Member

@lachlanjc lachlanjc commented Jan 29, 2022

Closes #1435, with a test!

πŸ“¦ Published PR as canary version: 0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0

✨ Test out this PR locally via:

npm install @theme-ui/color-modes@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/color@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/components@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/core@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/css@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/custom-properties@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/editor@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install gatsby-plugin-theme-ui@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install gatsby-theme-style-guide@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install gatsby-theme-ui-layout@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/match-media@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/mdx@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/parse-props@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-base@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-bootstrap@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-bulma@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-dark@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-deep@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-funk@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-future@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-polaris@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-roboto@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-sketchy@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-swiss@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-system@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-tailwind@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/preset-tosh@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/presets@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/prism@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/sidenav@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/style-guide@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/tailwind@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/theme-provider@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install theme-ui@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
npm install @theme-ui/typography@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
# or 
yarn add @theme-ui/color-modes@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/color@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/components@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/core@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/css@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/custom-properties@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/editor@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add gatsby-plugin-theme-ui@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add gatsby-theme-style-guide@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add gatsby-theme-ui-layout@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/match-media@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/mdx@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/parse-props@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-base@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-bootstrap@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-bulma@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-dark@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-deep@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-funk@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-future@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-polaris@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-roboto@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-sketchy@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-swiss@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-system@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-tailwind@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/preset-tosh@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/presets@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/prism@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/sidenav@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/style-guide@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/tailwind@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/theme-provider@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add theme-ui@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0
yarn add @theme-ui/typography@0.14.0--canary.2099.4e0c9a7a33b769d36ddad95e5cc950ee851d66b3.0

Version

Published prerelease version: v0.14.0-develop.6

Changelog

πŸŽ‰ This release contains work from a new contributor! πŸŽ‰

Thank you, Brage (@braaar), for all your work!

πŸš€ Enhancement

  • feat(examples/next): Add new deps, fully use TSX, rebuild #2068 (@lachlanjc)
  • @theme-ui/color-modes
    • feat(color-modes): Warn when theme color keys have leading/trailing whitespace #2099 (@lachlanjc)
  • theme-ui

πŸ› Bug Fix

πŸ‘¨β€πŸ’» Minor changes

  • docs(examples/next): fix case insensitive import (@hasparus)

🏠 Internal

Authors: 3

@vercel
Copy link

vercel bot commented Jan 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/systemui/theme-ui/B7nHZ9TgjiD1kQaKxB4AQZyW3Nx6
βœ… Preview: https://theme-ui-git-lachlanjc-warn-colorspace-systemui.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc64d2a:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

@hasparus
Copy link
Member

Sweet!

@hasparus
Copy link
Member

πŸš€ PR was released in v0.14.0 πŸš€

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
2 participants