Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Set text color on Demo page JSON code #2024

Merged
merged 1 commit into from Nov 29, 2021
Merged

fix(docs): Set text color on Demo page JSON code #2024

merged 1 commit into from Nov 29, 2021

Conversation

appsparkler
Copy link
Contributor

@appsparkler appsparkler commented Nov 27, 2021

Currently in dark-mode; the color is not visible as it assumes the default color which is black.

Version

Published prerelease version: v0.12.2-develop.2

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ Akash (@appsparkler)

❤️ Greg Poole (@gpoole)

🐛 Bug Fix

🏠 Internal

  • docs(pragma): add SWC instructions for Next.js #2020 (@gpoole)

Authors: 2

Currently in dark-mode; the color is not visible as it assumes the default color which is black.
@vercel
Copy link

vercel bot commented Nov 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/FRW8xx3WN3uWhBHMeuXLvHbqaXzg
✅ Preview: https://theme-ui-git-fork-appsparkler-patch-1-systemui.vercel.app

@lachlanjc lachlanjc changed the title fix: set color to text fix(docs): Set text color on Demo page JSON code Nov 29, 2021
Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent fix, thank you for the contribution!

@lachlanjc lachlanjc added the documentation Changes only affect the documentation label Nov 29, 2021
@lachlanjc lachlanjc merged commit 3931849 into system-ui:develop Nov 29, 2021
@hasparus hasparus added the prerelease This change is available in a prerelease. label Nov 29, 2021
@appsparkler appsparkler deleted the patch-1 branch December 4, 2021 13:27
@appsparkler
Copy link
Contributor Author

Excellent fix, thank you for the contribution!

@lachlanjc , the Edit Page link on the page made it very easy to do this. Excellent architecture 👍

@hasparus
Copy link
Member

🚀 PR was released in v0.13.0 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants