Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): add JSDoc comment to sx.label #1813

Merged
merged 1 commit into from Jun 11, 2021
Merged

fix(css): add JSDoc comment to sx.label #1813

merged 1 commit into from Jun 11, 2021

Conversation

hasparus
Copy link
Member

@hasparus hasparus commented Jun 10, 2021

Closes #1782.

πŸ“¦ Published PR as canary version: 0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0

✨ Test out this PR locally via:

npm install @theme-ui/color-modes@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/color@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/components@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/core@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/css@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/custom-properties@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/editor@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install gatsby-plugin-theme-ui@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install gatsby-theme-style-guide@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install gatsby-theme-ui-layout@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/match-media@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/mdx@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/parse-props@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-base@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-bootstrap@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-bulma@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-dark@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-deep@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-funk@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-future@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-polaris@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-roboto@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-sketchy@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-swiss@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-system@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-tailwind@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/preset-tosh@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/presets@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/prism@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/sidenav@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/style-guide@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/tachyons@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/tailwind@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/theme-provider@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install theme-ui@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
npm install @theme-ui/typography@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
# or 
yarn add @theme-ui/color-modes@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/color@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/components@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/core@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/css@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/custom-properties@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/editor@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add gatsby-plugin-theme-ui@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add gatsby-theme-style-guide@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add gatsby-theme-ui-layout@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/match-media@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/mdx@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/parse-props@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-base@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-bootstrap@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-bulma@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-dark@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-deep@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-funk@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-future@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-polaris@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-roboto@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-sketchy@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-swiss@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-system@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-tailwind@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/preset-tosh@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/presets@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/prism@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/sidenav@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/style-guide@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/tachyons@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/tailwind@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/theme-provider@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add theme-ui@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0
yarn add @theme-ui/typography@0.9.2-canary.1813.6b82d2a03bc978a0f2c515bc4daed437657d4d75.0

@vercel
Copy link

vercel bot commented Jun 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/systemui/theme-ui/FAtPeEKCwPqgn2Wtef33yGyufGP5
βœ… Preview: https://theme-ui-git-label-jsdoc-systemui.vercel.app

@hasparus hasparus requested a review from lachlanjc June 10, 2021 21:10
@hasparus
Copy link
Member Author

@jeffscottward do you think this will help make the label less surprising in the future?

Copy link
Collaborator

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasparus hasparus merged commit 3374dff into develop Jun 11, 2021
@hasparus hasparus deleted the label-jsdoc branch June 11, 2021 09:18
@hasparus
Copy link
Member Author

πŸš€ PR was released in v0.10.0 πŸš€

@hasparus hasparus added the released This issue/pull request has been released. label Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type Error: Label element is expected to be a string?
2 participants