Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all transitive peerDependencies are listed correctly and test Yarn 2/3 installs #2198

Open
hasparus opened this issue Apr 7, 2022 Discussed in #2196 · 2 comments
Labels
bug Something isn't working internal Changes only affect the internal API

Comments

@hasparus
Copy link
Member

hasparus commented Apr 7, 2022

We're currently causing peerDependency warnings in Yarn 2.
Whenever we depend on something, this dependencies peerDependencies must be listed either in our peerDependencies or in our dependencies.

Discussed in #2196

Originally posted by jw-miaem April 7, 2022
Reason I ask (before raising) is because I'm unable to get rid of 'doesn't provide ...' warning with yarn berry package.json install. I looked at the peerDependencies for @theme-ui/css for example and its "@emotion/react": "^11" and I have "@emotion/react": "^11.9.0" installed which I thought would satisfy but could be wrong

@hasparus hasparus added bug Something isn't working good first issue Good for newcomers labels Apr 7, 2022
@hasparus
Copy link
Member Author

This might be already fixed after we migrated to PNPM. We gotta test it with Yarn 3 and make sure it installs flawlessly.

cc @lachlanjc

@hasparus hasparus added internal Changes only affect the internal API and removed good first issue Good for newcomers labels Nov 23, 2022
@hasparus
Copy link
Member Author

Quoting from my post in the discussion:

Note for myself: Peer deps are now transitive and need to be explicitly listed in all libraries. We need a CI check for Yarn 2 and Yarn 3 installs.

To close this issue, we would need to continuously ensure that Theme UI can properly install in Yarn 3 projects.
The work needed is not the modification of some package.json file, it's a TypeScript or Bash script, a GitHub action step that would verify we're installing without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant