Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom SVGs for Radio & Checkbox components #2013

Open
MuhammadJamaluddin opened this issue Nov 15, 2021 · 3 comments
Open

Custom SVGs for Radio & Checkbox components #2013

MuhammadJamaluddin opened this issue Nov 15, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed @theme-ui/components

Comments

@MuhammadJamaluddin
Copy link

MuhammadJamaluddin commented Nov 15, 2021

Is your feature request related to a problem? Please describe.
I don't think Theme UI should be opinionated on which SVGs should be used for the Radio & CheckBox components

Describe the solution you'd like
Probably an additional prop called customIcon maybe... based on which we could conditionally render the passed SVG icon otherwise we use the default icons?

Describe alternatives you've considered
The alternative is obviously to rebuild the component from the ground up, but it's really counterproductive given that Theme UI have the component & API in place

Additional context
Theme UI should make it seamless to build a design system & enforcing a specific icon without giving the option to override it sounds a bit counterintuitive for me

@hasparus hasparus added the enhancement New feature or request label Nov 15, 2021
@MuhammadJamaluddin
Copy link
Author

MuhammadJamaluddin commented Nov 15, 2021

Actually, thinking about it, it probably has to be customIcons (an array), where we pass two SVGs, one for checked state & another one for the unchecked state

@sikhaman
Copy link

any updates on it?

@hasparus
Copy link
Member

@sikhaman It's not planed in foreseeable future, sorry. You can copy the Checkbox component into your codebase and change the icons there.

@lachlanjc lachlanjc changed the title Custom SVGs for Radio & Checkbox compnents Custom SVGs for Radio & Checkbox components Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed @theme-ui/components
Projects
None yet
Development

No branches or pull requests

4 participants