Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preset sketchy docs don't show its fonts and components. #1128

Closed
hasparus opened this issue Aug 13, 2020 · 0 comments · Fixed by #1236
Closed

Preset sketchy docs don't show its fonts and components. #1128

hasparus opened this issue Aug 13, 2020 · 0 comments · Fixed by #1236
Labels
affects-docs Changes affect documentation, but not only documentation

Comments

@hasparus
Copy link
Member

hasparus commented Aug 13, 2020 •
edited

Describe the bug

Preset sketchy docs don't show its fonts and components.

To Reproduce
Steps to reproduce the behavior:

  1. Go to preset-sketchy demo website. https://themeui-sketchy.netlify.app/
  2. Go to its page in Theme UI docs. https://theme-ui.com/presets/sketchy
  3. Notice the discrepancy.

Expected behavior

  • (minimum) Theme UI docs should dynamically fetch fonts for presets.
  • (would be nice) Theme UI docs could link to external preset's own docs with a Message at the top of the page?
  • (would be awesome) Presets could declare an MDX or JS file to be rendered in the docs?

Screenshots

demo website Theme UI docs
@hasparus hasparus added the affects-docs Changes affect documentation, but not only documentation label Aug 13, 2020
@hasparus hasparus mentioned this issue Aug 13, 2020
Merged
@atanasster atanasster mentioned this issue Nov 3, 2020
Merged
@lachlanjc lachlanjc linked a pull request Dec 2, 2020 that will close this issue
feat(docs): Add custom content for sketchy preset demo #1236
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-docs Changes affect documentation, but not only documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docs): Add custom content for sketchy preset demo atanasster/theme-ui
1 participant
@hasparus