gui, api: Indicate running under container

[calmh]

This adds a word to the version string when running containerized. The purpose is mostly to facilitate troubleshooting via screenshot by "leaking" this rather important aspect of the setup. Additionally, the version row gets "no-overflow-ellipsis" treatment so that the whole thing is actually visible in the GUI and the (now useless) tooltip is removed. In production releases this won't make a difference as the whole thing will typically fit, but in odd setups it provides more info up front.

Arguably this thing should be localized, but ... the version strings aren't currently, because they're proper names of sort, the "64-bit" part could be...

[bt90]

Could you add an environment detection for podman?

/run/.containerenv

The other two detection strategies don't seem to work in an alpine container (quickly tested in my ntfy container):

cat /proc/self/cgroup

returns 0::/

cat /proc/1/environ

doesn't contain anything container related.

I think those detection strategies are not valid anymore with cgroupv2?

[bt90]

Looks like detection isn't that easy: https://github.com/systemd/systemd/blob/5c8e19cc1cfc58cd65a8bfe0fea4ea16ea513dcf/src/basic/virt.c

I think we should check for docker, podman and kubernetes. If anybody has a valid strategy for LXC that might also be nice.

As for kubernetes: https://kubernetes.io/docs/tutorials/services/connect-applications-service/#environment-variables

It should be enough to check for the presence of KUBERNETES_SERVICE_HOST.

[bt90]

This might also be a nice addition for the usage report.

[calmh]

Yeah I can add more detection mechanisms. Note that I explicitly externalised the detection library because I don't want syncthing to have to maintain that as well.

[bt90]

Sounds good but my point is that the /proc stuff is going to be less useful as cgroupv1 being phased out. The other mechanisms cover both of them.

I would also add PID as a detection mechanism. If syncthing is running with PID 1, it's 99.999% running inside a container.

[calmh]

In syncthings case the process running the check won't be pid 1 unfortunately because of wrappers and monitor process, but it's a good additional check.

[bt90]

BSD seems to require sysctl: https://www.reddit.com/r/freebsd/comments/zuc2y6/detect_if_process_is_executed_inside_a_jail/j1i6cjt/

[calmh]

Yeah I don't particularly care about bsd here.

[tomasz1986]

Arguably this thing should be localized, but ... the version strings aren't currently, because they're proper names of sort, the "64-bit" part could be...

If this was to be translated, it should probably be treated as a whole with variables, as the word order differs between languages (e.g. "64-bit ARM" vs "ARM 64-bit", etc.) unless each part was divided with commas, e.g. "64-bit, ARM, container". Without any of those changes, I think it's probably better to leave "container" in English (especially since also the single word translation with no context may lead to funny things here), at least for the time being.

[acolomb]

Agreed, let's not open a can of worms regarding translations here.

Does the mechanism tell us what container technology is being used? If so, I'd put the specific abbreviation there instead of the generic word "container".

[bt90]

That would be neat. Some detection mechanisms would allow to do that. For others we would only get the information that it's some kind of container.

Maybe an enum like Docker, Podman, Generic and None ?

[calmh]

Thanks guys for the feedback, those are all good ideas that someone could contribute in the future! :)