Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createSharedEntry(...) when using query string versioning strategy #619

Merged
merged 1 commit into from Aug 9, 2019

Conversation

Lyrkan
Copy link
Collaborator

@Lyrkan Lyrkan commented Jul 23, 2019

This PR fixes #618 by correctly filtering the JS files of the shared entry (in the SharedEntryConcatPlugin) when versioning is handled in a query string.

@XWB
Copy link
Contributor

XWB commented Jul 24, 2019

Looks good. Any idea when it can be merged?

@Lyrkan
Copy link
Collaborator Author

Lyrkan commented Jul 24, 2019

@XWB I'm not sure... even if I merge it (which is something that I usually try to avoid on my own PRs) we'll have to wait for @weaverryan to release a new version, and he's quite busy right now.

However if you really need it you can directly use that branch (or fork the repository, apply the patch and do the same thing):

$ yarn remove @symfony/webpack-encore
$ yarn add git://github.com/lyrkan/webpack-encore.git#fix-shared-entry-query-param

Note that it is up-to-date with the current master though... so you'll also get some other unreleased things (the only BC break being that Encore won't support Node 9 anymore).

@XWB
Copy link
Contributor

XWB commented Jul 25, 2019

even if I merge it (which is something that I usually try to avoid on my own PRs)

Fair enough :)

we'll have to wait for @weaverryan to release a new version

If merged, we can also install the master branch, or lock to a specific commit.

However if you really need it you can directly use that branch (or fork the repository, apply the patch and do the same thing):

Thank you!

expect(getFileExtension('http://localhost/foo.js?abcd')).to.equal('js');
expect(getFileExtension('foo.txt?bar=baz&baz=bar')).to.equal('txt');
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I truly enjoy reviewing your PRs ❤️

@weaverryan
Copy link
Member

Just wonderful. Thank you @Lyrkan!

@weaverryan weaverryan merged commit 0f63369 into symfony:master Aug 9, 2019
weaverryan added a commit that referenced this pull request Aug 9, 2019
…g strategy (Lyrkan)

This PR was merged into the master branch.

Discussion
----------

Fix createSharedEntry(...) when using query string versioning strategy

This PR fixes #618 by correctly filtering the JS files of the shared entry (in the `SharedEntryConcatPlugin`) when versioning is handled in a query string.

Commits
-------

0f63369 Fix createSharedEntry(...) when using query string versioning strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared entry fails with configureFilenames
3 participants