Fix old integrity hashes being added to the entrypoints.json with --watch #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
integrity-hashes-watch-issue
branch
from
1986d97
to
eecebb7
Compare
stof
approved these changes
Jul 16, 2019
|
Thanks @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Aug 9, 2019
… with --watch (Lyrkan) This PR was merged into the master branch. Discussion ---------- Fix old integrity hashes being added to the entrypoints.json with --watch This PR fixes a really small issue that I noticed while working on #608. When using `--watch` and `enableIntegrityHashes()` together it works fine for the first compilation, but on the next ones the old hashes also get added to the `entrypoints.json` file. **First compilation:** ```json { "entrypoints": { "main": { "js": [ "/build/main.js" ] } }, "integrity": { "/build/main.js": "<OLDHASH>" } } ``` **Second compilation:** ```json { "entrypoints": { "integrity": { "/build/main.js": ["<OLDHASH>"] }, "main": { "js": [ "/build/main.js" ] } }, "integrity": { "/build/main.js": "<NEWHASH>" } } ``` Commits ------- eecebb7 Fix old integrity hashes being added to the entrypoints.json with --watch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a really small issue that I noticed while working on #608.
When using
--watchandenableIntegrityHashes()together it works fine for the first compilation, but on the next ones the old hashes also get added to theentrypoints.jsonfile.First compilation:
{ "entrypoints": { "main": { "js": [ "/build/main.js" ] } }, "integrity": { "/build/main.js": "<OLDHASH>" } }Second compilation:
{ "entrypoints": { "integrity": { "/build/main.js": ["<OLDHASH>"] }, "main": { "js": [ "/build/main.js" ] } }, "integrity": { "/build/main.js": "<NEWHASH>" } }