Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "sourceType" to "unambiguous" by default in Babel's options #555

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Lyrkan
Copy link
Collaborator

@Lyrkan Lyrkan commented Apr 7, 2019

This PR fixes #552 by setting the sourceType option of Babel to unambiguous by default.

For more details about the reasons behind this change, see #552 (comment).

@Lyrkan
Copy link
Collaborator Author

Lyrkan commented Apr 7, 2019

One of the jobs currently fails due to a bug in the new version of mocha released a few hours ago (see mochajs/mocha#3866).

@weaverryan
Copy link
Member

Thank you @Lyrkan!

@weaverryan weaverryan merged commit 0ccbcff into symfony:master Apr 10, 2019
weaverryan added a commit that referenced this pull request Apr 10, 2019
…ons (Lyrkan)

This PR was merged into the master branch.

Discussion
----------

Set "sourceType" to "unambiguous" by default in Babel's options

This PR fixes #552 by setting the `sourceType` option of Babel to `unambiguous` by default.

For more details about the reasons behind this change, see #552 (comment).

Commits
-------

0ccbcff Set "sourceType" to "unambiguous" by default in Babel's options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require appears to not work with useBuiltIns: usage
2 participants