Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): fix peerDependency constraints for vue and vue-loader #1160

Merged
merged 1 commit into from Oct 19, 2022

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Oct 17, 2022

Fix #1158

My bad, I should have checked the syntax to allow both versions.
Friendly ping @weaverryan

@weaverryan
Copy link
Member

This is already merged and tagged - not sure why the PR didn't close :)

@weaverryan weaverryan closed this Oct 19, 2022
@Kocal
Copy link
Contributor Author

Kocal commented Oct 19, 2022

@weaverryan this is a new PR to fix #1158, after https://github.com/symfony/webpack-encore/releases/tag/v4.1.0 has been released.

@stof stof reopened this Oct 19, 2022
@IonBazan
Copy link

I confirm, without this fix, the package cannot be installed:

$ npm upgrade @symfony/webpack-encore
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name "^2.6|^3.2.14" of package "vue@^2.6|^3.2.14": Tags may not have any characters that encodeURIComponent encodes.

@weaverryan
Copy link
Member

My mistake - thanks @Kocal!

@weaverryan weaverryan merged commit 1d54c54 into symfony:main Oct 19, 2022
@Kocal Kocal deleted the patch-1 branch October 19, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants