From ae5fea132a95fca6b289dbd320acc0f1ca037a90 Mon Sep 17 00:00:00 2001 From: Wim Hendrikx Date: Mon, 16 Sep 2019 17:01:30 +0200 Subject: [PATCH 1/2] bug #638 sass-loader should not do css minification --- lib/loaders/sass.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/loaders/sass.js b/lib/loaders/sass.js index 9f9858b2..002fe6b9 100644 --- a/lib/loaders/sass.js +++ b/lib/loaders/sass.js @@ -41,7 +41,9 @@ module.exports = { const config = Object.assign({}, { // needed by the resolve-url-loader - sourceMap: (true === webpackConfig.sassOptions.resolveUrlLoader) || webpackConfig.useSourceMaps + sourceMap: (true === webpackConfig.sassOptions.resolveUrlLoader) || webpackConfig.useSourceMaps, + // CSS minification is handled with mini-css-extract-plugin + outputStyle: 'expanded' }); sassLoaders.push({ From f55fb908ad365e4f22eb9167e1768aa2bdc57c13 Mon Sep 17 00:00:00 2001 From: Wim Hendrikx Date: Mon, 16 Sep 2019 22:47:44 +0200 Subject: [PATCH 2/2] Adapt test for new sass-loader config --- test/loaders/sass.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/loaders/sass.js b/test/loaders/sass.js index e3fe1b98..90772a07 100644 --- a/test/loaders/sass.js +++ b/test/loaders/sass.js @@ -120,6 +120,7 @@ describe('loaders/sass', () => { expect(actualLoaders[1].options).to.deep.equals({ sourceMap: true, + outputStyle: 'expanded', custom_optiona: 'baz', other_option: true });