Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Contracts] Update dependency to use symfony/service-contracts #65

Merged
merged 1 commit into from Jul 3, 2019
Merged

[Contracts] Update dependency to use symfony/service-contracts #65

merged 1 commit into from Jul 3, 2019

Conversation

wbrinkman
Copy link
Contributor

@wbrinkman wbrinkman commented May 30, 2019 •
edited by nicolas-grekas

Updated requirement symfony/contracts to symfony/service-contracts so having this bundle in a Symfony 4.3 installation does not generate ambiguous classes with an optimized composer autoloader.

Fixes #64

@vkhramtsov
Copy link

@wbrinkman @nicolas-grekas Any news here?

@javiereguiluz
Copy link
Member

I just saw this in the Symfony Demo app. Looking forward to the merge and new version release! Thank you.

$ composer dump-autoload -o

Restricting packages listed in "symfony/symfony" to "4.3.*"
Generating optimized autoload files

Warning: Ambiguous class resolution, "Symfony\Contracts\Cache\CallbackInterface" was found in both "vendor/symfony/cache-contracts/CallbackInterface.php" and "vendor/symfony/contracts/Cache/CallbackInterface.php", the first will be used.

Warning: Ambiguous class resolution, "Symfony\Contracts\Cache\ItemInterface" was found in both "vendor/symfony/cache-contracts/ItemInterface.php" and "vendor/symfony/contracts/Cache/ItemInterface.php", the first will be used.

Warning: Ambiguous class resolution, "Symfony\Contracts\Cache\CacheInterface" was found in both "vendor/symfony/cache-contracts/CacheInterface.php" and "vendor/symfony/contracts/Cache/CacheInterface.php", the first will be used.

[...]

@javer
Copy link

javer commented Jun 18, 2019

Any update on this?
I see 25 warnings every time I run composer in Symfony 4.3 project with this bundle.

@javer
Copy link

javer commented Jun 24, 2019

@weaverryan Could you please press "Merge pull request" button and make a new release? We already have 3 approvals in this PR.

@tompiard
Copy link

tompiard commented Jul 1, 2019 •
edited

I love how webpack encore improved my frontend workflow in so many ways. But the wait for this PR is very worrisome. It is a very basic commit that keep this bundle in sync with the Symfony ecosystem that it's supposed to be part of.

@luispabon
Copy link

Anybody else have merge & versioning rights that could possibly push this through the finishing line pls?

@javer
Copy link

javer commented Jul 1, 2019

@weaverryan @nicolas-grekas @fabpot Please help someone to press Merge button in this PR, which is ready for a month, has 3 approvals and have just been ignored one more time during creating a new release 5 hours ago.

@weaverryan
Copy link
Member

Sorry - will merge tonight. This bundle is my responsibility and I’ve been a bit busy - apologies for the inconvenience!

@weaverryan
Copy link
Member

Thank you @wbrinkman! And sorry again for the delay - thanks for everyone's patience!

@weaverryan weaverryan merged commit 2ec86a5 into symfony:master Jul 3, 2019
weaverryan added a commit that referenced this pull request Jul 3, 2019
@weaverryan
bug #65 [Contracts] Update dependency to use symfony/service-contract…
5e1cab3 
…s (wbrinkman)

This PR was merged into the master branch.

Discussion
----------

[Contracts] Update dependency to use symfony/service-contracts

Updated requirement symfony/contracts to symfony/service-contracts so having this bundle in a Symfony 4.3 installation does not generate ambiguous classes with an optimized composer autoloader.

Fixes #64

Commits
-------

2ec86a5 Update dependency to use symfony/service-contracts to prevent autoloading clashes with Symfony 4.3
@luispabon
Copy link

Thank you @weaverryan 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@vkhramtsov vkhramtsov vkhramtsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symfony 4.3 / Composer: Ambiguous class resolution for symfony/contracts
8 participants
@wbrinkman @vkhramtsov @javiereguiluz @javer @tompiard @luispabon @weaverryan @nicolas-grekas