Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json not updated #228

Open
fishbone1 opened this issue Mar 22, 2024 · 0 comments
Open

package.json not updated #228

fishbone1 opened this issue Mar 22, 2024 · 0 comments

Comments

@fishbone1
Copy link

It seems that the package.json is not updated when updating webpack-encore-bundle. If your point is that devs have to maintain the package.json theirselves and keep it in sync with webpack-encore-bundle, then the contents of it should be documented.

I got a cryptic error after updating an older Symfony project:

Error: Cannot find module '@babel/core'

Please consider that updating (ideally) happens more often than installation, so it is even more important. (I wonder why there often are only nice solutions for the latter. Do other people re-write their applications all the time? Or they don't update dependencies at all?)

I'm curious why you didn't define those dependenies (e.g. @babel/core) as sub-dependencies of webpack-encore? This is what I assumed initially, so it took me a while to figure out that something's wrong with my package.json.

Anyway, this is my update process at the moment (as a workaround):

  • rename move package.json, yarn.lock and node_modules
  • composer remove symfony/webpack-encore-bundle
  • composer req symfony/webpack-encore-bundle
  • Check new package.json and adjust original package.json
  • Replace new package.json by old one
  • yarn install

This was a similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant