You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you have no permissions to write to assets directrory you'll just get a php warning in prod enviroment (as warnings does not converts to exceptions there).
It is not right to say "all right" when it is not I think. And return exit code 0. bash scripts with set -e continue executing with not installed assets in CI (for example). Good that assets:compile throw exeption like "you did not run importmap:install", but problem was in another place.
21:14:28 WARNING [php] Warning: file_put_contents(/var/www/html/assets/vendor/installed.php): Failed to open stream: No such file or directory ["exception" => ErrorException { …}]
[OK] Downloaded 1 package into assets/vendor.
…nandre)
This PR was squashed before being merged into the 6.4 branch.
Discussion
----------
[AssetMapper] Check asset/vendor directory is writable
| Q | A
| ------------- | ---
| Branch? | 6.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues | Fix#54719
| License | MIT
💐
Commits
-------
7c2da27 [AssetMapper] Check asset/vendor directory is writable
Symfony version(s) affected
6.4.6
Description
If you have no permissions to write to
assets
directrory you'll just get a php warning in prod enviroment (as warnings does not converts to exceptions there).It is not right to say "all right" when it is not I think. And return exit code 0. bash scripts with
set -e
continue executing with not installed assets in CI (for example). Good thatassets:compile
throw exeption like "you did not run importmap:install", but problem was in another place.How to reproduce
Possible Solution
Check that downloded package exists and throw exception otherwise.
Additional Context
The text was updated successfully, but these errors were encountered: