Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][Messenger] Remove ResetLoggersWorkerSubscriber #43271

Closed
lyrixx opened this issue Oct 1, 2021 · 1 comment · Fixed by #43322
Closed

[RFC][Messenger] Remove ResetLoggersWorkerSubscriber #43271

lyrixx opened this issue Oct 1, 2021 · 1 comment · Fixed by #43322
Labels
Messenger RFC RFC = Request For Comments (proposals about features that you want to be discussed)

Comments

@lyrixx
Copy link
Member

lyrixx commented Oct 1, 2021

Hello,

Since #41163 and #43133 I think #40761 is not needed anymore.

TL;DR:

=> The first feature embrace the the last one, and will be shipped by default.

That's why I propose to remove all code related to #40761.

ping @upyx @okwinza

@l-vo I'm deeply sorry for trying to remove your code. I know it's really unpleasant when someone want to remove our code. But in this case, I think it's legit. It simplifies the Symfony code base, project configuration, and documentation.


If everyone is OK, I'll work on a PR.

@carsonbot carsonbot added Messenger RFC RFC = Request For Comments (proposals about features that you want to be discussed) labels Oct 1, 2021
@fabpot
Copy link
Member

fabpot commented Oct 1, 2021

#40761 has been introduced in 5.3, not 5.4, so we need a proper deprecation in 5.4 and full removal on 6.0.
👍 for doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Messenger RFC RFC = Request For Comments (proposals about features that you want to be discussed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants