Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symfony/messenger: Tests/ directory went missing after symfony update from 4.3.11 -> 4.4.8 #36752

Closed
xatham opened this issue May 8, 2020 · 2 comments

Comments

@xatham
Copy link

xatham commented May 8, 2020

Symfony version(s) affected: symfony/messenger ^4.4

Description

(not sure if composer or symfony repository issue)

The Tests directory of my symfony/messenger dependency goes missing after an update from symfony 4.3 to ^4.4

How to reproduce
In my specific case i was just switching the composer version for some packages from 4.3.* to 4.4.*
After clearing composer cache and running composer update symfony/messenger
these components were updated:


diff --git a/composer.json b/composer.json
index 2ac12a6..35061a6 100644
--- a/composer.json
+++ b/composer.json
@@ -13,10 +13,10 @@
   },
   "require": {
     "php": "^7.3",
-    "symfony/http-kernel": "4.3.*",
-    "symfony/dependency-injection": "4.3.*",
-    "symfony/config": "4.3.*",
-    "symfony/messenger": "4.3.*",
+    "symfony/http-kernel": "4.4.*",
+    "symfony/dependency-injection": "4.4.*",
+    "symfony/config": "4.4.*",
+    "symfony/messenger": "4.4.*",

- Updating symfony/http-foundation (v4.4.8 => v5.0.8)
- Installing symfony/var-dumper (v5.0.8):
-  Installing symfony/error-handler (v4.4.8)
- Updating symfony/http-kernel (v4.3.11 => v4.4.8):
- Updating symfony/service-contracts (v1.1.8 => v2.0.1):
- Updating symfony/dependency-injection (v4.3.11 => v4.4.8)
- Updating symfony/filesystem (v4.4.8 => v5.0.8):
- Updating symfony/config (v4.3.11 => v4.4.8):
And
  - Updating symfony/messenger (v4.3.11 => v4.4.8): Downloading https://api.github.com/repos/symfony/messenger/zipball/518595aaf10a177623685be49b585c09e96aedc3
Downloading (connecting...)
Following redirect (2) https://codeload.github.com/symfony/messenger/legacy.zip/518595aaf10a177623685be49b585c09e96aedc3
Downloading https://codeload.github.com/symfony/messenger/legacy.zip/518595aaf10a177623685be49b585c09e96aedc3

When i switch back to 4.3, the Tests file is back.
When i download the symfony package via one of those links directly the Tests dir is also missing.

Possible Solution

Additional context
If im completely wrong in here, please provide a place where i can get help with this issue.

@xatham xatham added the Bug label May 8, 2020
@xatham xatham changed the title Tests/ directory went missing after symfony update from 4.3.11 -> 4.4.8 symfony/messenger: Tests/ directory went missing after symfony update from 4.3.11 -> 4.4.8 May 8, 2020
@linaori
Copy link
Contributor

linaori commented May 8, 2020

The Test directories have been removed from the dist version: see #33579. The tests should not be part of your dependencies.

If you want to get the tests back, you can install the source variant by using composer install --prefer-source

Status: reviewed

@xabbuh
Copy link
Member

xabbuh commented May 8, 2020

This was done on purpose as explained by @linaori. So I am going to close here.

@xabbuh xabbuh closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants