Fix the translation commands when a template contains a syntax error

[fabpot]

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #34586
License	MIT
Doc PR	n/a

When using debug:translation or translation:update, we should catch exceptions to avoid breaking the command. It was not really an issue before Symfony 4.4/5 as we didn't have templates in the core that use features from optional dependencies.

[stof]

This is not the right fix IMO: this catches the errors at the level of a Twig top-level folder. So it will ignore any other template in the same folder if one of them has an issue (so ignoring twig-bridge entirely for instance). We should rather catch things for each template separately, to keep processing others.

[stof]

Also, doing this in the extractor would also mean that it applies to other tools using the extractor.

[fabpot]

I would not do it at the extractor level as it would mean that we would not be able to emit a notice (which might be fine after all). Ignoring a directory is not a problem IMO as there is a syntax error that should be fixed if this is a directory in the user project, and for built-in templates, we don't really care.

[stof]

well, bundles might have some templates used for specific case like that. And this extractor would then skip the whole bundle templates.

The translation extractor is not responsible for linting templates (we have a command for that), and ignoring valid templates makes it less useful.

[fabpot]

@stof code updated :)

[nicolas-grekas]

But tests should be updated :)