[Config] don't break on virtual stack frames in ClassExistenceResource #34695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 28, 2019
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #34665 |
| License | MIT |
| Doc PR | - |
|
this is the same issue than #34636 but with a fix targetting the right lowest branch, right ? If yes, why is the fix different ? |
|
That's a different class, not the same job/code. |
ahmedash95
reviewed
Nov 29, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2019
…enceResource (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Config] don't break on virtual stack frames in ClassExistenceResource | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34665 | License | MIT | Doc PR | - Commits ------- fffeccd [Config] don't break on virtual stack frames in ClassExistenceResource
This was referenced Dec 1, 2019
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.