[Security] Fix clearing remember-me cookie after deauthentication #34671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
rememberme-logout
branch
from
34907fd
to
e83fa6c
Compare
src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Firewall/ContextListener.php
Outdated
Show resolved
Hide resolved
chalasr
force-pushed
the
rememberme-logout
branch
4 times, most recently
from
18ca151
to
1f57f19
Compare
nicolas-grekas
approved these changes
Nov 29, 2019
chalasr
force-pushed
the
rememberme-logout
branch
4 times, most recently
from
fb29008
to
1ab423f
Compare
chalasr
force-pushed
the
rememberme-logout
branch
from
1ab423f
to
d625a73
Compare
fabpot
approved these changes
Nov 30, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2019
…ication (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [Security] Fix clearing remember-me cookie after deauthentication | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #26379 | License | MIT | Doc PR | - If you are using the `remember_me` listener and the refreshed user is deauthenticated, you are still logged in because the remember-me cookie does not get cleared. This fixes it. Commits ------- d625a73 [Security] Fix clearing remember-me cookie after deauthentication
chalasr
commented
Nov 30, 2019
| @@ -537,6 +538,9 @@ private function createAuthenticationListeners($container, $id, $firewall, &$aut | |||
| } elseif ('remember_me' === $key) { | |||
There was a problem hiding this comment.
Careful when merging up: this condition also includes anonymous === $key as of 4.4, it needs to be split so that this applies only to remember_me.
| always_remember_me: true | ||
| secret: key | ||
| anonymous: ~ | ||
| logout_on_user_change: true |
There was a problem hiding this comment.
to be removed starting from 4.3
Merged
This was referenced Dec 1, 2019
Merged
Merged
Merged
|
this broke my application. can't login anymore, I am being redirected to login page even with correct credentials. downgrading to SF |
|
@gondo please open an issue with enough information to reproduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are using the
remember_melistener and the refreshed user is deauthenticated, you are still logged in because the remember-me cookie does not get cleared.This fixes it.