more robust initialization from request #34649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request::getPort is declared as int|string but can actually return null.
I discovered this problem with a functional test where i dispatch the RequestEvent with a
new Request()
. This used to work in symfony 4 and now triggers an errorArgument 1 passed to Symfony\Component\Routing\RequestContext::setHttpPort() must be of the type int, null given
In regular web requests, this should probably never happen, but it seems to me if Request is not robust, the RequestContext should be robust about it.