New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twig-bundle dependencies missing to include inky_to_html-filter, resulting in error when updating translations #34586
Comments
Hello @knallcharge, Did you add the library with : Cheers 😉 |
That's what the bug is all about: shouldn't the requirement be added automatically? |
i think... no. Because you can use twig without this. |
Symfony 4.4 requires symfony/twig-bridge and that requires twig/inky-extra, but is not included when using composer update. Please check the stackoverflow-link. |
@fabpot weren't we ignoring Twig templates producing a syntax error when extracting translations, instead of failing the whole extraction ? |
I have the same error. I don't want to install |
…ntax error (fabpot) This PR was merged into the 3.4 branch. Discussion ---------- Fix the translation commands when a template contains a syntax error | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #34586 | License | MIT | Doc PR | n/a When using `debug:translation` or `translation:update`, we should catch exceptions to avoid breaking the command. It was not really an issue before Symfony 4.4/5 as we didn't have templates in the core that use features from optional dependencies. Commits ------- 7f803bc Fix the translation commands when a template contains a syntax error
I see this is supposed to be fixed, but I just started using translations and got the same error message complaining about missing To get rid of the error message and to get Am I supposed to install all those packages manually, or is there maybe a problem that brought this issue back? |
Symfony version(s) affected: 4.4.0
Description
After updating from Symfony 4.3 to 4.4 (changing composer.json manually and using composer update), I'm faced with the error message "In body.html.twig line 1: Unknown "inky_to_html" filter." when trying to update my translations (bin/console tran:up ).
How to reproduce
Migrate Symfony to 4.4 by changing composer.json & calling composer update
Execute php bin/console tran:up
Possible Solution
When in the project directory, adding the dir to the command is a workaround:
php bin/console tran:up .
Additional context
https://stackoverflow.com/questions/59029924/symfony-4-4-unknown-inky-to-html-filter also has my composer.json (as I can't attach it here)
The text was updated successfully, but these errors were encountered: