[Config][ReflectionClassResource] Handle parameters with undefined constant as their default values #34560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
config-reflection-class-undef-constant
branch
from
6ec8085
to
6ea7b07
Compare
|
Some tests fail, but this looks promising! |
fancyweb
force-pushed
the
config-reflection-class-undef-constant
branch
3 times, most recently
from
4dbcaa4
to
ab35a71
Compare
|
I fixed the code for PHP <= 7.0. |
src/Symfony/Component/Config/Resource/ReflectionClassResource.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
config-reflection-class-undef-constant
branch
2 times, most recently
from
13231fc
to
b955f83
Compare
…nstant as their default values
fancyweb
force-pushed
the
config-reflection-class-undef-constant
branch
from
b955f83
to
8de2a22
Compare
nicolas-grekas
approved these changes
Nov 29, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2019
…ndefined constant as their default values (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Config][ReflectionClassResource] Handle parameters with undefined constant as their default values | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34053 | License | MIT | Doc PR | - Basically we can fix this bug by "reimplementing" php src way of building the __toString() of the method except that we avoid to call the undefined constant. Obviously we cannot invalidate the resource if the value of the constant changes since we never knew it. However, it's still better than now. Commits ------- 8de2a22 [Config][ReflectionClassResource] Handle parameters with undefined constant as their default values
This was referenced Dec 1, 2019
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically we can fix this bug by "reimplementing" php src way of building the __toString() of the method except that we avoid to call the undefined constant. Obviously we cannot invalidate the resource if the value of the constant changes since we never knew it. However, it's still better than now.